Skip to content

5 click point to view attribute us6 #21

Merged
merged 20 commits into from
Oct 6, 2025

Conversation

gautegf
Copy link
Member

@gautegf gautegf commented Oct 1, 2025

No description provided.

@gautegf gautegf self-assigned this Oct 1, 2025
@gautegf gautegf linked an issue Oct 1, 2025 that may be closed by this pull request
@mariewah mariewah self-requested a review October 1, 2025 10:53
Added title for the measurement list, and for the data display. Moved some options from scene to measurements tab. Added opening and closing transition to the tab
Copy link
Member

@adriahso adriahso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, the UI looks really good. Made some comments. Also, which script did you use inn order to keep attributes (e.g. acceptance, TVU, THU) during the conversion?

@gautegf
Copy link
Member Author

gautegf commented Oct 4, 2025

@adriahso I have the converter script outside of the repo. Its basically the script that Tobias made a while ago, with some adjustments. Do you need it?
Let me know if there are still some bugs with this branch!

@adriahso
Copy link
Member

adriahso commented Oct 5, 2025

@adriahso I have the converter script outside of the repo. Its basically the script that Tobias made a while ago, with some adjustments. Do you need it? Let me know if there are still some bugs with this branch!

Well, without it I can't really see the attributes of our data like accepted, TVU and THU, which would be nice. Maybe just put the script somewhere in the Google Drive?

@gautegf
Copy link
Member Author

gautegf commented Oct 5, 2025

Uploaded to google drive now: converter.py

@adriahso
Copy link
Member

adriahso commented Oct 5, 2025

Nice, could see it now. Some minor things:

  • Would it be possible to go back to how the section is in the menu originally with "Select a measurement to view its properties here" and no measurement data title when all measurements have been removed, and also just remove the measurement data title completely if you remove the point that was previously selected?
  • Do we want an extra section title similarly to how it is in the "Elevation Control" section, where there is also an "Elevation" under title. Could maybe look nice?
  • Is the padding between the tool images and "Show/Hide labels" less here than how it was originally?

@gautegf
Copy link
Member Author

gautegf commented Oct 5, 2025

Nice, could see it now. Some minor things:

  • Would it be possible to go back to how the section is in the menu originally with "Select a measurement to view its properties here" and no measurement data title when all measurements have been removed, and also just remove the measurement data title completely if you remove the point that was previously selected?
  • Do we want an extra section title similarly to how it is in the "Elevation Control" section, where there is also an "Elevation" under title. Could maybe look nice?
  • Is the padding between the tool images and "Show/Hide labels" less here than how it was originally?

Yeah the measurements data title was useless, so I removed it. Should look cleaner now. Also cleaned up the UI (titles/dividers and spacing)

Let me know if there is something else I've missed.

This files turned out larger than I expected, which is due to making a custom UI for the measurements and also because volumes and profiles are handled differently, but I'm sure the code can be cleaner. If time allows it i want to revisit this at the end of the project (which it probably wont)

Copy link
Member

@mariewah mariewah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me!

Copy link
Member

@adriahso adriahso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gautegf gautegf merged commit 8d36734 into dev Oct 6, 2025
Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Click point to view attribute US:6
3 participants